Matthias Clasen [Wed, 13 Feb 2019 20:08:17 +0000 (15:08 -0500)]
inspector: Support list model properties
This is just a very quick hack for a property editor
that allows to drill down into list models.
Matthias Clasen [Wed, 13 Feb 2019 19:14:54 +0000 (14:14 -0500)]
stack: Add a pages property
This makes the list model available in the inspector.
Matthias Clasen [Wed, 13 Feb 2019 18:41:15 +0000 (13:41 -0500)]
inspector: Make object property inspection work again
This was lost when porting to GtkListView.
Matthias Clasen [Wed, 13 Feb 2019 18:40:40 +0000 (13:40 -0500)]
inspector: Add an api to activate an object
This will be used to make object property inspection
work again.
This will be used to make object property inspection
work againn
Matthias Clasen [Wed, 13 Feb 2019 18:04:00 +0000 (13:04 -0500)]
inspector: Fix selecting objects with a next tab
This was causing criticals.
Matthias Clasen [Wed, 13 Feb 2019 17:47:11 +0000 (12:47 -0500)]
Add a missing icon
The view-refresh-symbolic icon is used in the data list
of the inspector. So ship it in gtk. No need to have
it in the demos, then.
Matthias Clasen [Wed, 13 Feb 2019 14:01:07 +0000 (09:01 -0500)]
stack: Don't emit bad ::selection-changed signals
We have to be careful to not pass bad numbers to
this signal, which was happening in cases where
we have on old or new selected item.
Matthias Clasen [Wed, 13 Feb 2019 14:00:00 +0000 (09:00 -0500)]
stack: Fix a corner-case
When the stack goes empty, we were failing to reset
the visible_child member to NULL, causing problems later
on, since we don't have a ref for it.
Matthias Clasen [Wed, 13 Feb 2019 13:42:58 +0000 (08:42 -0500)]
stack: Don't leak a reference
The page holds a reference to the widget, so can't just clear
this pointer.
Matthias Clasen [Wed, 13 Feb 2019 13:40:13 +0000 (08:40 -0500)]
stack: Avoid some ugly unrefs
Instead of using the list model api that forces us
to drop the ref, just work with the list we have.
Matthias Clasen [Wed, 13 Feb 2019 13:38:30 +0000 (08:38 -0500)]
selection model: Add sanity checks
It is easy to emit wrong ::selection-changed signals,
and then bad things will usually happen later. Add
some sanity checks to gtk_selection_model_selection_changed
to make this easier to track down.
Matthias Clasen [Wed, 13 Feb 2019 03:33:16 +0000 (03:33 +0000)]
Merge branch 'included-icons' into 'master'
Included icons
See merge request GNOME/gtk!580
Matthias Clasen [Wed, 13 Feb 2019 02:35:54 +0000 (21:35 -0500)]
Update check-icon-names tests
Drop icons that are only used by demos, and check for ones
that are actually used in gtk.
Matthias Clasen [Wed, 13 Feb 2019 00:44:13 +0000 (19:44 -0500)]
gtk-demo: Include our own icons
Add enough icons as resources that gtk4-demo
works without an installed icon theme.
Matthias Clasen [Wed, 13 Feb 2019 01:25:06 +0000 (20:25 -0500)]
stack demo: Use the proper icon name
The gtk-demo logo was renamed. Follow suit.
Matthias Clasen [Wed, 13 Feb 2019 01:24:27 +0000 (20:24 -0500)]
sidebar demo: Use an existing icon
The help-about icon is legacy and not available in large sizes.
Just use the gtk-demo logo.
Matthias Clasen [Wed, 13 Feb 2019 00:05:03 +0000 (19:05 -0500)]
widget-factory: Include our own icons
Add enough icons as resources that gtk4-widget-factory
works without an installed icon theme.
Matthias Clasen [Tue, 12 Feb 2019 22:44:20 +0000 (17:44 -0500)]
page setup dialog: Use theme icons
We have non-gtk-specific icons in the icon theme for this
now, so drop the gtk-orientation icons and use the theme
ones instead.
Matthias Clasen [Tue, 12 Feb 2019 20:24:55 +0000 (15:24 -0500)]
spin button: Use guaranteed icons
We guarantee value-increase/decrease-symbolic now, no need
for fallback anymore.
Matthias Clasen [Tue, 22 Jan 2019 22:27:15 +0000 (17:27 -0500)]
resources: Include more icons
Include all the icons that gtk is using itself.
For now, we include size 16 and scalable, to keep
the size limited.
Matthias Clasen [Tue, 12 Feb 2019 17:40:17 +0000 (12:40 -0500)]
resources: Include more icon directories
We are going to include all the icons that are
used by gtk itself. Prepare for that by including
the necessary subdirectories from the icon theme.
Matthias Clasen [Tue, 12 Feb 2019 18:31:58 +0000 (13:31 -0500)]
icon theme: Remove fallbacks
We want to include all needed icons as resources,
so disable the fallbacks and see what comes up.
Matthias Clasen [Tue, 12 Feb 2019 17:13:05 +0000 (12:13 -0500)]
Add image-missing to the internal icons
We assert if image-missing is missing,
so life is better if
we can guarantee that it is available.
Matthias Clasen [Tue, 12 Feb 2019 17:56:23 +0000 (12:56 -0500)]
testsuite: Consider bookmark-new as required icon
This was missing from the list.
Timm Bäder [Tue, 12 Feb 2019 05:33:41 +0000 (06:33 +0100)]
Rever more of the icon shadow commit
Even adjusting the icon size is wrong for GTK4.
Matthias Clasen [Mon, 14 Jan 2019 02:56:00 +0000 (21:56 -0500)]
Revert a non-working addition
Cell rendererers don't support <style> in ui files.
Jakub Steiner [Mon, 10 Dec 2018 13:16:52 +0000 (14:16 +0100)]
Theme: add helper class names for Adwaita
- helps legibility of app icons
Addresses https://gitlab.gnome.org/GNOME/gtk/issues/1434
Matthias Clasen [Tue, 12 Feb 2019 05:10:00 +0000 (00:10 -0500)]
about dialog: Adapt to new stack visiblity handling
We need to set the visible property of the stack pages
now.
Piotr Drąg [Mon, 11 Feb 2019 21:27:57 +0000 (22:27 +0100)]
Update POTFILES.in
Matthias Clasen [Mon, 11 Feb 2019 16:48:25 +0000 (16:48 +0000)]
Merge branch 'fix-fishbowl' into 'master'
gtk-demo: Fix fishbowl setup
Closes #1665
See merge request GNOME/gtk!578
Matthias Clasen [Mon, 11 Feb 2019 13:24:06 +0000 (08:24 -0500)]
gtk-demo: Fix fishbowl setup
The fishbowl demo was failing to reset a static variable
when setting up, causing it to crash the second time around.
Closes: #1665
Matthias Clasen [Mon, 11 Feb 2019 04:40:33 +0000 (04:40 +0000)]
Merge branch 'stack-fixes' into 'master'
Stack <> switcher api changes
See merge request GNOME/gtk!570
Matthias Clasen [Mon, 11 Feb 2019 04:04:44 +0000 (23:04 -0500)]
Exclude some tests on too-old glib
I'm coming to the conclusion that the ci test
failures are due to a recently fixed bug in
GListStore.
Matthias Clasen [Mon, 11 Feb 2019 03:19:28 +0000 (22:19 -0500)]
add more autoselect tests
Matthias Clasen [Mon, 11 Feb 2019 02:15:57 +0000 (21:15 -0500)]
Reorder tests
Trying to get to the bottom of a ci failure
Matthias Clasen [Mon, 11 Feb 2019 02:08:44 +0000 (21:08 -0500)]
selection tests: Plug a memory leak
Matthias Clasen [Sun, 10 Feb 2019 23:44:16 +0000 (23:44 +0000)]
Merge branch 'fix-typo' into 'master'
typo correction
See merge request GNOME/gtk!573
Matthias Clasen [Fri, 8 Feb 2019 23:32:28 +0000 (18:32 -0500)]
stack: Drop the position property
GtkStackSwitcher and GtkStackSidebar no longer
use the GtkStackPage::position property, so we
don't need to maintain it anymore.
Matthias Clasen [Fri, 8 Feb 2019 23:27:10 +0000 (18:27 -0500)]
stack sidebar: Use the selection model
Make GtkStackSidebar and GtkStack communicate via
the selection model that GtkStack now exposes.
This is parallel to the GtkStackSwitcher changes
in the previous commit.
Matthias Clasen [Sun, 10 Feb 2019 03:47:13 +0000 (22:47 -0500)]
a11y tests: Adapt to changes
The buttons in the stack switcher are now toggle buttons, no
longer radio buttons. Update expected output for that.
Matthias Clasen [Sat, 9 Feb 2019 01:38:01 +0000 (20:38 -0500)]
stack switcher: Use the selection model
Make GtkStackSwitcher and GtkStack communicate via
the selection model that GtkStack now exposes.
Matthias Clasen [Sun, 10 Feb 2019 23:22:54 +0000 (18:22 -0500)]
stack: Provide a selection model
Make GtkStack expose a selection model for its pages.
The model can be used to track changes to the pages,
and to change what child is visible.
Matthias Clasen [Sun, 10 Feb 2019 23:13:03 +0000 (18:13 -0500)]
stack: Add a GtkStackPage::visible property
This will let GtkStackSwitcher track visibility
without having to interact with the widgets directly.
Matthias Clasen [Sun, 10 Feb 2019 03:54:37 +0000 (22:54 -0500)]
testsuite: omit some selection properties
The selected property of GtkSingleSelection is not
freely settable, so omit it from notification tests.
Matthias Clasen [Sun, 6 Jan 2019 17:57:42 +0000 (12:57 -0500)]
testsuite: Add selection model tests
Benjamin Otte [Wed, 3 Oct 2018 16:51:52 +0000 (18:51 +0200)]
gtk: Add GtkSingleSelection
GtkSingleSelection is a GtkSelectionModel that allows selecting a single
item.
Benjamin Otte [Wed, 3 Oct 2018 16:49:48 +0000 (18:49 +0200)]
gtk: Add GtkSelectionModel
The selection model is a list model interface that takes care of
selections and is to be used by the list model widgets to manage their
selections.
Matthias Clasen [Fri, 8 Feb 2019 23:27:56 +0000 (18:27 -0500)]
gtk-demo: Fix the sidebar demo
It was still using child properties.
Timm Bäder [Sun, 10 Feb 2019 15:42:17 +0000 (16:42 +0100)]
demo: Fix fishbowl default togglebutton state
Timm Bäder [Sun, 10 Feb 2019 09:07:24 +0000 (10:07 +0100)]
glglyphcache: Fix dropping caches unnecessarily
The first set of glyphs is created with a timestamp of 1. Later we
subtract the glyph timestamp from the cache timestamp, meaning we end up
with numbers ending in 9, e.g. 59. Now unfortunately !(60 <= 59), so we
do not end up incrasing the old_pixels count of the cache. Later we then
call lookup() and DEcrease the old_pixels count, which makes the
unsigned int wrap and cause a huge old_pixels value, which causes us to
drop the cache.
Timm Bäder [Fri, 8 Feb 2019 10:01:39 +0000 (11:01 +0100)]
glglyphcache: Remove surface member from dirty glyph
We don't use it after we've rendered to it, just its size and data.
Timm Bäder [Sun, 10 Feb 2019 09:28:32 +0000 (10:28 +0100)]
window: Remove GList link directly
Instead of walking the list again and looking for the GList pointer we
already have.
Timm Bäder [Sun, 10 Feb 2019 09:27:27 +0000 (10:27 +0100)]
rendericon: Ignore transparent icons
If the recoloring would end up multiplying the alpha component with 0
anyway, just skip drawing anything altogether.
This increases the icon count in the switch demo of the fishbowl from
~260 to ~280 on my system.
Timm Bäder [Tue, 5 Feb 2019 15:05:06 +0000 (16:05 +0100)]
GdkDisplay: Use a GQueue for the events queue
Jiri Grönroos [Sat, 9 Feb 2019 18:38:51 +0000 (18:38 +0000)]
Update Finnish translation
(cherry picked from commit
68a7da71e32187dad70fb5913f20bff6e8476ec8)
Fran Dieguez [Sat, 9 Feb 2019 15:35:06 +0000 (15:35 +0000)]
Update Galician translation
Matthias Clasen [Sat, 9 Feb 2019 15:09:59 +0000 (15:09 +0000)]
Merge branch 'wip/jimmac/app-icons' into 'master'
Wip/jimmac/app icons
Closes #1658
See merge request GNOME/gtk!572
Matthias Clasen [Sat, 9 Feb 2019 14:20:25 +0000 (09:20 -0500)]
flatpak: Stop renaming icons
We are now installing properly named icons, no need to
rename anymore.
This was causing ci to fail.
Fran Dieguez [Sat, 9 Feb 2019 12:43:44 +0000 (12:43 +0000)]
Update Galician translation
John Zhang [Sat, 9 Feb 2019 06:43:21 +0000 (14:43 +0800)]
typo correction
Matthias Clasen [Sat, 9 Feb 2019 02:38:14 +0000 (21:38 -0500)]
Fix icon installation
This makes the apps pick up their awesome new icons.
Carlos Garnacho [Sat, 9 Feb 2019 01:06:51 +0000 (01:06 +0000)]
Merge branch 'wip/carlosg/toggle-osk-sparingly-master' into 'master'
imwayland: Toggle OSK more sparingly
Closes #1277
See merge request GNOME/gtk!571
Carlos Garnacho [Fri, 8 Feb 2019 22:11:48 +0000 (23:11 +0100)]
imwayland: Toggle OSK more sparingly
Specifically it is avoided to be toggled if:
- Just received focus (in order to preserve OSK state across focus changes)
- Moving cursor around. Still allow some jitter as perfect accuracy is not
possible.
Closes: https://gitlab.gnome.org/GNOME/gtk/issues/1277
Piotr Drąg [Fri, 8 Feb 2019 19:17:25 +0000 (20:17 +0100)]
Update Polish translation
Matthias Clasen [Fri, 8 Feb 2019 18:48:11 +0000 (13:48 -0500)]
Avoid introspection warnings
Unless we keep the parameter names in headers sources and
docs the same, some tools will complain.
Piotr Drąg [Fri, 8 Feb 2019 18:24:53 +0000 (19:24 +0100)]
Use Unicode typography in new translatable strings
See https://developer.gnome.org/hig/stable/typography.html
Piotr Drąg [Fri, 8 Feb 2019 18:16:35 +0000 (19:16 +0100)]
Update POTFILES.in
Benjamin Otte [Fri, 8 Feb 2019 17:18:55 +0000 (18:18 +0100)]
revealer: Use gtk_widget_set_overflow()
Benjamin Otte [Fri, 8 Feb 2019 17:16:35 +0000 (18:16 +0100)]
treeview: Use gtk_widget_set_overflow()
We need to clip again so we don't overdraw the headers, but setting
overflow does the right thing with header widgetry.
Benjamin Otte [Fri, 8 Feb 2019 17:16:16 +0000 (18:16 +0100)]
textview: Use gtk_widget_set_overflow()
Benjamin Otte [Fri, 8 Feb 2019 17:16:07 +0000 (18:16 +0100)]
magnifier: Use gtk_widget_set_overflow()
Benjamin Otte [Fri, 8 Feb 2019 17:15:57 +0000 (18:15 +0100)]
iconview: Use gtk_widget_set_overflow()
Benjamin Otte [Fri, 8 Feb 2019 17:15:50 +0000 (18:15 +0100)]
paned: Use gtk_widget_set_overflow()
Benjamin Otte [Fri, 8 Feb 2019 17:05:40 +0000 (18:05 +0100)]
viewport: Use gtk_widget_set_overflow()
Benjamin Otte [Fri, 8 Feb 2019 17:02:40 +0000 (18:02 +0100)]
widget: Add gtk_widget_set_overflow()
This adds a simple abilities for widget implementations to clip their
content. See future commits for users of this.
Matthias Clasen [Fri, 8 Feb 2019 15:33:11 +0000 (10:33 -0500)]
builder-tool: Fix preserving properties
We were looking at the wrong class names here, we need
to look at the owner type to match against our list.
This fixes problems where gtk-builder-tool simplify
inadvertedly loses hexpand or vexpand settings, messing
up layout, as recently happend in gtk4-widget-factory.
Matthias Clasen [Fri, 8 Feb 2019 15:32:23 +0000 (10:32 -0500)]
widget-factory: Reinstate some lost properties
The code in gtk-builder-tool to preserve properties
has a bug, It lost these.
Matthias Clasen [Fri, 8 Feb 2019 15:01:22 +0000 (15:01 +0000)]
Merge branch 'idle-test-recentmanager' into 'master'
tests: Bulk add recent items in an idle
See merge request GNOME/gtk!568
Matthias Clasen [Fri, 8 Feb 2019 14:56:14 +0000 (09:56 -0500)]
a11y tests: Update actionbar output
This changed with box packing changes.
Matthias Clasen [Fri, 8 Feb 2019 14:40:27 +0000 (09:40 -0500)]
a11y tests: Update dialog-related output
There was a change in internal dialog structure that
is reflected in this output.
Matthias Clasen [Fri, 8 Feb 2019 14:51:02 +0000 (09:51 -0500)]
a11y tests: Update assistant ui file
The conversion was done with gtk-builder-tool simplify --3to4.
Matthias Clasen [Fri, 8 Feb 2019 14:29:01 +0000 (09:29 -0500)]
a11y tests: Update stack ui file
The conversion was done with gtk-builder-tool simplify --3to4.
Matthias Clasen [Fri, 8 Feb 2019 14:49:54 +0000 (09:49 -0500)]
assistant: Fix a refcounting oversight
The assistant needs to hold a ref on the pages.
Emmanuele Bassi [Fri, 8 Feb 2019 14:37:21 +0000 (14:37 +0000)]
tests: Bulk add recent items in an idle
Instead of adding them and waiting for the changed signal to be emitted
in the main loop, there might be a race where the change signal is
emitted before we have a chance of spinning the loop.
Matthias Clasen [Fri, 8 Feb 2019 14:04:08 +0000 (09:04 -0500)]
notify test: Omit GtkStackPage::position
We can't change positions without a stack.
Matthias Clasen [Fri, 8 Feb 2019 14:03:45 +0000 (09:03 -0500)]
stack: Fix up property notification
This was showing up in testsuite failures.
Matthias Clasen [Fri, 8 Feb 2019 14:03:18 +0000 (09:03 -0500)]
assistant: Fix up property notification
This was showing up in testsuite failures.
Matthias Clasen [Fri, 8 Feb 2019 13:22:35 +0000 (08:22 -0500)]
stack: Make the child meta work without stack
We have tests that expect this to work, like defaultvalue.
Matthias Clasen [Fri, 8 Feb 2019 13:22:06 +0000 (08:22 -0500)]
shortcuts window: Fix a leftover use of child properties
These properties are gone, use the child meta here.
Matthias Clasen [Fri, 8 Feb 2019 13:21:42 +0000 (08:21 -0500)]
assistant: Fix the default value of has-padding
This was showing up in the defaultvalue test.
Matthias Clasen [Fri, 8 Feb 2019 12:55:41 +0000 (07:55 -0500)]
Fix compiler warnings
Fallout from recent GtkStackPage changes.
Emmanuele Bassi [Fri, 8 Feb 2019 10:49:24 +0000 (10:49 +0000)]
ci: Update the test suite name
The project name is "gtk", not "gtk+".
Matthias Clasen [Fri, 8 Feb 2019 05:22:30 +0000 (05:22 +0000)]
Merge branch 'stackpage' into 'master'
Stack page
See merge request GNOME/gtk!564
Matthias Clasen [Thu, 7 Feb 2019 20:34:54 +0000 (15:34 -0500)]
builder-tool: Convert assistant pages too
Do the same transformation for GtkAssistantPage that
we already do for GtkStackPage, to transform GTK 3 .ui
files to GTK 4 ways of doing things.
Matthias Clasen [Thu, 7 Feb 2019 20:18:49 +0000 (15:18 -0500)]
assistant: Convert child properties to a child meta object
Turn GtkAssistantPage into a public object holding the
former child properties.
Matthias Clasen [Thu, 7 Feb 2019 18:12:07 +0000 (13:12 -0500)]
migration guide: Mention --3to4
Matthias Clasen [Thu, 7 Feb 2019 18:04:57 +0000 (13:04 -0500)]
Some small additions to the migration guide
Mention some of the recent changes, such as GtkButtonBox,
GtkBox, child properties.
Matthias Clasen [Thu, 7 Feb 2019 08:23:02 +0000 (03:23 -0500)]
Update ui files to new stack syntax
This conversion was done with the help of gtk4-builder-tool.
Matthias Clasen [Thu, 7 Feb 2019 17:24:49 +0000 (12:24 -0500)]
builder tool: Operate on multiple files
There is no strong reason to disallow this, when
the --replace option is used.
Matthias Clasen [Thu, 7 Feb 2019 16:57:09 +0000 (11:57 -0500)]
Document --3to4